customization - Custom WP_Query with no posts to output in WordPress

Empty argument here doest equal logical inthing . It equals value to process and so WP ignores it and goes further as usual.

Just wrap your query in if( !empty( $favorites) ) condition.